Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify MintUrl, use it directly in wallet/client.rs #410

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

ok300
Copy link
Contributor

@ok300 ok300 commented Oct 20, 2024

This PR simplifies how MintUrl is handled:

  • args that represent a mint URL are given the explicit MintUrl type, instead of Url and a later try_into conversion
  • as a consequence, TryInto implementations were not used anymore to convert between MintUrl and Url and were removed
  • a few unused error types were also removed (in fact they were duplicated)
  • the class method join_url was converted to a method of MintUrl for better readability

@ok300 ok300 force-pushed the ok300-simplify-minturl-handling branch from fe9d98d to 98c94e2 Compare October 20, 2024 17:53
Copy link
Collaborator

@thesimplekid thesimplekid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great this is much cleaner. Love a negative git diff

@thesimplekid thesimplekid merged commit 103574b into cashubtc:main Oct 22, 2024
42 checks passed
@ok300 ok300 deleted the ok300-simplify-minturl-handling branch October 22, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants