mintd: sort pks by amount in /v1/keys
#406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ok300
force-pushed
the
ok300-mintd-sort-keyset-keys
branch
from
803434b to
cdded19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings two related changes:
/v1/keys/{keyset_id}are sorted by amount. Before, they were sorted alphabetically for theStringrepresentation ofAmounts("123", "2", "33"vs now"2", "33", "123").Idgeneration, namely the sorting of pubkeys. Before, there were two conversions (AmounttoStringtou64) before sorting, for eachPublicKey. Now, the two conversions are skipped and the keys are directly sorted byAmount.