-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cdk_sdk):remove spent proof and update db state #393
Conversation
@thesimplekid do you have time review this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let spent_ys: Vec<_> = spendable
.states
.iter()
.filter_map(|p| match p.state {
State::Spent => Some(p.y),
_ => None,
})
.collect();
self.localstore.update_proofs(vec![], spent_ys).await?;
This needs to be added to the check_proofs_spent
fn as mentioned in the issue not the restore fn. The restore fn does not need to be changed
i understand |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix the fmt error then rebase and squash the commits
i dont think there is a need for a rebase, my fork repo is up to date with main branch. will fix the fmt error |
@thesimplekid watch your workshop session via youtube at bitcoinplusplus, will you push the implementation on github repo |
Sure its here thesimplekid/btcpp_cdk_wallet#1 by the way there is a cdk channel in the cashu discord that can be used for more general chats |
the discord link is failing, can you drop the invite link |
PR For issue: #353
This PR add spent proof pub keys as the second params in
update_proofs
function,i figure out since the update proof function do two thing
instead of creating another function that collect spent proof and remove them, i filter through the proofs and collect the spent proof pub key and add it as the second params that
update_proofs