Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate workspace metadata #388

Closed

Conversation

ok300
Copy link
Contributor

@ok300 ok300 commented Oct 3, 2024

Since the crates are organized in a workspace, we can define most metadata fields in the workspace Cargo.toml and simply reference them in the member crates Cargo.tomls.

This makes maintenance easier. For example, version needs to be updated only in one place when releasing a new version. At the same time, it also gives us the flexibility to set a custom value for a member crate and overwrite the workspace value, if needed.

Note: In dependencies that were specified by path, like

cdk = { path = "../cdk", version = "0.4.0", default-features = false, features = ["mint"] }

the version was removed, since it's ignored by Cargo anyway. Instead, Cargo uses the code under that path, regardless of specified version.

@ok300
Copy link
Contributor Author

ok300 commented Oct 3, 2024

Too bad, looks like the workspace-inheritance feature is only available starting with MSRV 1.64.0, which is higher than the current 1.63.0.

@ok300 ok300 closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant