Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to_unit into amount module #381

Merged
merged 2 commits into from
Oct 1, 2024
Merged

Refactor to_unit into amount module #381

merged 2 commits into from
Oct 1, 2024

Conversation

davidcaseria
Copy link
Contributor

In a couple of my codebases, I've found it helpful to expose the to_unit outside of a mint setting. Since cdk_lightning is behind the mint feature, I think moving it into the amount module would be beneficial so that the mint feature does not need to be enabled.

thesimplekid
thesimplekid approved these changes Oct 1, 2024
View reviewed changes
Copy link
Collaborator

@thesimplekid thesimplekid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@thesimplekid thesimplekid merged commit fc0cc67 into cashubtc:main Oct 1, 2024
36 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesimplekid thesimplekid thesimplekid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidcaseria @thesimplekid