Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bolt12 #370

Closed
wants to merge 27 commits into from
Closed

feat: bolt12 #370

wants to merge 27 commits into from

Conversation

thesimplekid
Copy link
Collaborator

@thesimplekid thesimplekid commented Sep 28, 2024

Backend Send Receive
CLN ✔️ ✔️
LND* 🚧 🚧
PHD** ✔️ :
LNBITS
Strike***

* With use of LNDK as lnd does not directly support bolt12
** PHD doesnt allow creation of one time use bolt12, so receive cannot be supported
*** Strike api doesn't seem to support bolt12, coming soon?

@thesimplekid thesimplekid force-pushed the bolt12 branch 5 times, most recently from f78fd32 to 139fe9f Compare October 4, 2024 07:06
@thesimplekid thesimplekid force-pushed the bolt12 branch 3 times, most recently from 1ab593c to e6a0b87 Compare October 6, 2024 16:20
@thesimplekid thesimplekid changed the title feat: pay bolt12 (backends not impl) feat: bolt12 Oct 8, 2024
@@ -75,7 +75,7 @@ enum Commands {
#[tokio::main]
async fn main() -> Result<()> {
let args: Cli = Cli::parse();
let default_filter = args.log_level;
let default_filter = "debug";
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set this back to arg

}

pub async fn pay(
multi_mint_wallet: &MultiMintWallet,
sub_command_args: &MeltSubCommand,
) -> Result<()> {
let unit = CurrencyUnit::from_str(&sub_command_args.unit)?;
let unit = CurrencyUnit::from_str(&sub_command_args.unit).unwrap();
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove unwrap

@thesimplekid
Copy link
Collaborator Author

close for #404

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant