Implemented new struct 'MintUrl' which trims trailing slashes. #283
Conversation
There was a problem hiding this comment.
Thanks for this. With this change we can completely remove the UncheckedUrl in favor or MintUrl.
Also since we need to account for databases that already have mints with trailing slashes in them since with this change we wont be able to get them since the lookup id will be the url without a / I suggest we add a migration that trims the trailing / from the db. In sql this can be done by adding a migration file via the cli and using sql trim. In redb we can bump the db version number and then write a function to trip urls with trailing /.
crates/cdk/src/mint_url.rs
Outdated
| S: Into<String>, | ||
| { | ||
| let url: String = url.into(); | ||
| Self(url.trim_end_matches("/").to_string()) |
There was a problem hiding this comment.
| Self(url.trim_end_matches("/").to_string()) | |
| Self(url.trim_end_matches('/').to_string()) |
crates/cdk/src/mint_url.rs
Outdated
|
|
||
| /// Remove trailing slashes from url | ||
| pub fn trim_trailing_slashes(&self) -> Self { | ||
| Self(self.to_string().trim_end_matches("/").to_string()) |
There was a problem hiding this comment.
| Self(self.to_string().trim_end_matches("/").to_string()) | |
| Self(self.to_string().trim_end_matches('/').to_string()) |
crates/cdk/src/mint_url.rs
Outdated
| { | ||
| fn from(url: S) -> Self { | ||
| let url: String = url.into(); | ||
| Self(url.trim_end_matches("/").to_string()) |
There was a problem hiding this comment.
| Self(url.trim_end_matches("/").to_string()) | |
| Self(url.trim_end_matches('/').to_string()) |
|
@thesimplekid I added SQL migrations to remove trailing slashes from existing mint_urls. I'm not as familiar with redb, would you be able to make the necessary changes for that? |
crates/cdk-sqlite/src/mint/migrations/20240811031111_update_mint_url.sql
Outdated
Show resolved
Hide resolved
crates/cdk-sqlite/src/wallet/migrations/20240810233905_update_mint_url.sql
Outdated
Show resolved
Hide resolved
Implemented new struct 'MintUrl' which trims trailing slashes. Added missing import. Removed references to 'UncheckedUrl'. Added migrations to strip trailing slashes from mint_urls. Update crates/cdk-sqlite/src/mint/migrations/20240811031111_update_mint_url.sql Co-authored-by: thesimplekid <[email protected]> Update crates/cdk-sqlite/src/wallet/migrations/20240810233905_update_mint_url.sql Co-authored-by: thesimplekid <[email protected]> Update crates/cdk/src/mint_url.rs Co-authored-by: thesimplekid <[email protected]> feat: migrate wallet db for mint_url chore: formatting Fixed imports.
cjbeery24
force-pushed
the
feature/mint-url-trim-slashes
branch
from
0380e88 to
b762ced
Compare
I wasn't sure if I should insert the trim functionality into the existing "UncheckedUrl" implementation, so I created a similar but new "MintUrl" which seems more appropriately named anyway.
For:
#267