Remove widgets individually in the protocol #2503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
force-pushed
the
jw.single-remove.2024-12-10
branch
2 times, most recently
from
ea052a6 to
33affc0
Compare
This is required to efficiently implement movableContentOf in a future change.
JakeWharton
force-pushed
the
jw.single-remove.2024-12-10
branch
from
33affc0 to
36abbaa
Compare
squarejesse
reviewed
Dec 11, 2024
|
|
||
| @Suppress("DEPRECATION") // Testing for old behavior. | ||
| @Test | ||
| fun removeRangeForOldVersions() = runTest { |
There was a problem hiding this comment.
I'm actually thinking this behavior switching is pointless now. I broke this change out of the large one, but it's always valid to send individual removes to any host. So we always can do it and only worry about whether or not it's valid to send detach=true or not.
There was a problem hiding this comment.
Just going to leave it for now, land the rest which are kinda stacked on it, and then maybe delete.
There was a problem hiding this comment.
Yeah I got rid of this in #2509.
squarejesse
reviewed
Dec 11, 2024
| @@ -208,7 +214,13 @@ internal class FastGuestProtocolAdapter( | |||
| val tag = tag | |||
| val index = index | |||
| val count = count | |||
| changes.push(js("""["remove",{"id":id,"tag":tag,"index":index,"count":count}]""")) | |||
| if (hostSupportsRemoveDetachAndNoCount) { | |||
There was a problem hiding this comment.
I assume in follow-up we'll change the caller to use a different function?
squarejesse
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to efficiently implement
movableContentOfin a future change.See #1902
CHANGELOG.md's "Unreleased" section has been updated, if applicable.