Dispose of the composition when we're done with it. #2494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a test for DisposableEffect callbacks. #2248
swankjesse
force-pushed
the
jwilson.1209.disposable_test
branch
from
7bba4bc to
596d8aa
Compare
swankjesse
changed the title
swankjesse
commented
Dec 9, 2024
| @@ -79,6 +80,7 @@ internal object JvmHeap : Heap { | |||
|
|
|||
| // Don't traverse further on types that are unlikely to contain application-scoped data. | |||
| // We want to avoid loading the entire application heap into memory! | |||
| instance is AtomicLongFieldUpdater<*> -> listOf() | |||
There was a problem hiding this comment.
Tests demanded this
JakeWharton
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially I'm adding just the test we already pass, where the effect is executed because it is removed from the composition.
#2248