Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guest-side API for new insets #2463

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

swankjesse
Copy link
Collaborator

No description provided.

* desired behavior.
*/
@Composable
public fun ConsumeInsets(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn’t borrow the ComposeUI API directly 'cause it uses ComposeUI modifiers which we don’t have!

@swankjesse
Copy link
Collaborator Author

#919

Comment on lines +32 to +34
uiConfigurations.value = uiConfigurations.value.copy(
viewInsets = Margin(top = 30.dp),
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's nice when an API pays dividends and makes testing this easy

@swankjesse swankjesse force-pushed the jwilson.1118.insets_ios branch from 0123ace to 911138f Compare November 20, 2024 20:10
@swankjesse swankjesse force-pushed the jwilson.1119.insets_runtime branch from be1a85e to 1a60f52 Compare November 20, 2024 20:12
Base automatically changed from jwilson.1118.insets_ios to trunk November 20, 2024 22:16
@swankjesse swankjesse force-pushed the jwilson.1119.insets_runtime branch from 1a60f52 to eced783 Compare November 20, 2024 22:17
@squarejesse squarejesse enabled auto-merge (squash) November 20, 2024 22:18
@squarejesse squarejesse merged commit 5d5a2ff into trunk Nov 21, 2024
11 checks passed
@squarejesse squarejesse deleted the jwilson.1119.insets_runtime branch November 21, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants