Host-side insets for iOS UIViews #2462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
approved these changes
Nov 20, 2024
redwood-widget/src/iosMain/kotlin/app/cash/redwood/widget/RedwoodUIView.kt
Outdated
Show resolved
Hide resolved
|
The newly-added test fails like this in CI: I haven’t been able to extract more information than that. I can’t catch an exception or anything. And it passes locally. I assume something I’m doing with the UIWindow is failing 'cause either the code to do it isn’t there (a linking problem), or because the environment it’s running in isn’t there (headless?). |
swankjesse
force-pushed
the
jwilson.1118.insets_ios
branch
from
7020b18 to
0123ace
Compare
…oodUIView.kt Co-authored-by: Jake Wharton <[email protected]>
Otherwise it crashes in CI.
swankjesse
force-pushed
the
jwilson.1118.insets_ios
branch
from
0123ace to
911138f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.