Host-side API for view-owned widgets #2458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces a new mutable property, windowInsets, that is propagated to the composition where it can be consumed. We put the burden on the user of RedwoodView to set this value to something non-zero if they have insets to be consumed. I've added an accelerator on Android for this, RedwoodLayout.consumeWindowInsets(mask: Int)
swankjesse
force-pushed
the
jwilson.1118.insets
branch
from
c5b65db to
c1ac72b
Compare
squarejesse
commented
Nov 18, 2024
| @@ -112,7 +118,7 @@ public open class RedwoodLayout( | |||
|
|
|||
| private fun computeUiConfiguration( | |||
| config: Configuration = context.resources.configuration, | |||
| insets: Insets = rootWindowInsetsCompat.safeDrawing, | |||
There was a problem hiding this comment.
☠️
This is the core problem of the old API. If we end up calling this function for a configuration change, it forgets what the view-local insets were and reverts to the window insets.
squarejesse
commented
Nov 18, 2024
| * | ||
| * See https://developer.android.com/develop/ui/views/layout/edge-to-edge | ||
| */ | ||
| public val viewInsets: Margin = Margin.Zero, |
There was a problem hiding this comment.
Unfortunately safeAreaInsets are potentially non-zero on already-shipping clients, but they don’t necessarily apply to the view we want them to.
Instead I’m creating another property that’s my attempt at fixing the window-local vs. view-local problem.
JakeWharton
approved these changes
Nov 20, 2024
Comment on lines
+118
to
+120
| val value2 = awaitItem() | ||
| assertThat(value2.safeAreaInsets).isEqualTo(Margin.Zero) | ||
| assertThat(value2.viewInsets).isEqualTo(expectedInsets) |
There was a problem hiding this comment.
Change log item for this behavior change? Probably want to give a heads-up to internal users as well, if they still exist, that is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new mutable property, windowInsets, that is propagated to the composition where it can be consumed.
We put the burden on the user of RedwoodView to set this value to something non-zero if they have insets to be consumed. I've added an accelerator on Android for this,