Handle resizes of items in LazyColumn on iOS #2450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hooks up the recently-introduced ResizableWidget.SizeListener interface to UIViewLazyList. Unfortunately it's introducing unexpected additional measure calls to rows unimpacted by size changes. I suspect this is a bug in UITableView. Closes: #1254
squarejesse
commented
Nov 13, 2024
There was a problem hiding this comment.
The old layout was too tall!
squarejesse
commented
Nov 14, 2024
There was a problem hiding this comment.
The old layout was too tall!
| } | ||
|
|
||
| internal fun setContent(content: UIView?) { | ||
| removeAllSubviews() |
There was a problem hiding this comment.
I inlined removeAllSubviews() here, and changed it to use the new content property
JakeWharton
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hooks up the recently-introduced ResizableWidget.SizeListener interface to UIViewLazyList.
Unfortunately it's introducing unexpected additional measure calls to rows unimpacted by size changes. I suspect this is a bug in UITableView.
Closes: #1254
CHANGELOG.md's "Unreleased" section has been updated, if applicable.