Switch back to MutableMap to avoid scatter map bug
#2438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
commented
Nov 8, 2024
Comment on lines
+239
to
+241
| idToNode[lastCreatedId.value] = ReuseNode( | ||
| widgetId = lastCreatedId, |
There was a problem hiding this comment.
Switch to local which already has the same value as change.id
JakeWharton
commented
Nov 8, 2024
| changesAndNulls: Array<Change?>, | ||
| pooled: ProtocolNode<W>, | ||
| ) { | ||
| // Reuse the node. | ||
| pooled.id = widgetId |
There was a problem hiding this comment.
No need to lookup the Create, we already have a member with the new ID.
|
Took a quick look around at other scatter-based map and set usage. They don't have this long-lived put/remove pattern. |
squarejesse
reviewed
Nov 8, 2024
| childrenTag = ChildrenTag.Root, | ||
| idToNode[lastCreatedId.value] = ReuseNode( | ||
| widgetId = lastCreatedId, | ||
| // This is the root of the reuse tree, so it will never have a children tag from a parent. |
squarejesse
approved these changes
Nov 8, 2024
Sometimes the scatter-based maps can return values from other keys when inserting a new key. See https://issuetracker.google.com/issues/378077858.
JakeWharton
force-pushed
the
jw.mutable-map.2024-11-08
branch
from
2052c85 to
0fc9fff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the scatter-based maps can return values from other keys when inserting a new key. See https://issuetracker.google.com/issues/378077858.
CHANGELOG.md's "Unreleased" section has been updated, if applicable.