Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept a ZiplineHttpClient creating a TreehouseAppFactory #2436

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

swankjesse
Copy link
Collaborator

The current OkHttpClient is what we ultimately want to provide, but that forces us to create the OkHttpClient eagerly and we'd rather do that lazily.


  • CHANGELOG.md's "Unreleased" section has been updated, if applicable.

The current OkHttpClient is what we ultimately want to provide,
but that forces us to create the OkHttpClient eagerly and we'd
rather do that lazily.
Copy link
Collaborator

@JakeWharton JakeWharton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS too?

@swankjesse
Copy link
Collaborator Author

I don’t think iOS is as opinionated on how its networking is initialized.

@swankjesse swankjesse merged commit 71a75dd into trunk Nov 11, 2024
11 checks passed
@swankjesse swankjesse deleted the jwilson.1108.zipline_http_client branch November 11, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants