Fix Overflow.Scroll to fill its enclosing container #2430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was broken for YogaUIView, which collapsed the contents of scrollable content to the minimum required.
swankjesse
force-pushed
the
jwilson.1106.fill
branch
from
ad24959 to
fabf749
Compare
squarejesse
commented
Nov 6, 2024
There was a problem hiding this comment.
(This isn’t correct either)
squarejesse
commented
Nov 6, 2024
There was a problem hiding this comment.
Extremely incorrect
squarejesse
commented
Nov 6, 2024
There was a problem hiding this comment.
This is the test result without the fix:
edahle
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken for YogaUIView, which collapsed the contents of scrollable content to the minimum required.