Split Treehouse lifecycle out of RedwoodView #2418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My BIG INSIGHT in this PR is that everything works better if I expose content state two ways:
All of my previous attempts were clumsy because they treated these two cases as symmetric. |
JakeWharton
approved these changes
Oct 30, 2024
| @@ -425,7 +425,7 @@ private class RootProtocolNode<W : Any>( | |||
| } | |||
|
|
|||
| override fun detach() { | |||
| children.detach() | |||
| // Do nothing because 'children' is owned by the host's TreehouseView. | |||
There was a problem hiding this comment.
The Redwood protocol doesn't strictly have to be used by Treehouse, although that is certainly the overwhelmingly common usage. Maybe put a note on the class docs up above, or on close().
There was a problem hiding this comment.
Yeah, good point. I should have said RedwoodView here instead.
There was a problem hiding this comment.
Oh even better. I thought it was something specific to treehouse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2392
CHANGELOG.md's "Unreleased" section has been updated, if applicable.