Make UIViewBox use the same patterns as ViewBox #2400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now include the margin when measuring on 'Stretch' alignment. This was causing a layout bug previously. We now use sizeThatFits exclusively, rather than using sizeThatFits when measuring and systemLayoutSizeFittingSize during layout.
swankjesse
commented
Oct 23, 2024
swankjesse
commented
Oct 23, 2024
| is Height -> with(Density.Default) { | ||
| height = maxOf(height, childModifier.height.toPx()) | ||
| } | ||
| if (!mustMeasureWidth && !mustMeasureHeight) { |
There was a problem hiding this comment.
Android doesn’t have this optimization. It might benefit from it.
There was a problem hiding this comment.
(It’s more difficult because on Android measuring may have essential side-effects)
JakeWharton
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now include the margin when measuring on 'Stretch' alignment. This was causing a layout bug previously.
We now use sizeThatFits exclusively, rather than using sizeThatFits when measuring and systemLayoutSizeFittingSize during layout.