Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply Defaults explicitly #2395

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Apply Defaults explicitly #2395

merged 2 commits into from
Oct 22, 2024

Conversation

swankjesse
Copy link
Collaborator

No description provided.

squarejesse
squarejesse reviewed Oct 22, 2024
View reviewed changes
...hots/images/app.cash.redwood.layout.view_ViewBoxTest_RTL_testChildren_Wrap_Center_Center.png
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now frame the iOS and Android box widgets the same way, so we get consistent results between platforms.

https://github.com/cashapp/redwood/blob/trunk/redwood-layout-uiview/RedwoodLayoutUIViewTests/__Snapshots__/UIViewBoxTestHost/testChildren_Wrap_Center_Center.1.png

@swankjesse swankjesse merged commit abaf089 into trunk Oct 22, 2024
11 checks passed
@swankjesse swankjesse deleted the jwilson.1022.box_fixes branch October 22, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squarejesse squarejesse squarejesse left review comments

@JakeWharton JakeWharton JakeWharton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swankjesse @JakeWharton @squarejesse