-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flatten RedwoodView and RedwoodView.Root #2391
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a step in simplifying the complex interaction between these two classes. It also removes an unnecessary layer from the view tree. We also had a potential bug on hot reloads, where the previous content was detached but not necessarily removed. With this change we clear the child views by default on a hot reload.
squarejesse
commented
Oct 21, 2024
if (child is ExceptionView || child is LoadingView) { | ||
i.remove() | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let the base class just clear everything
JakeWharton
approved these changes
Oct 21, 2024
squarejesse
commented
Oct 21, 2024
loadCount: Int, | ||
attached: Boolean, | ||
uncaughtException: Throwable? = null, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a follow-up, I’ll refactor these arguments to match what the content can actually be:
sealed class ContentState {
/**
* This view has no content. This is the initial state of the view.
*
* This may occur if the content is gracefully stopped, in which case
* the view may continue to display the previous content, though it
* will not be interactive.
*/
object Detached : ContentState
/**
* Content isn't ready yet. It’s busy downloading, launching, or computing
* the initial view tree.
*/
object Loading : ContentState()
/**
* Content is ready and responsive to interactions.
*/
data class Attached(val loadCount: Int): ContentState()
/**
* This view has crashed due to a bug.
*/
data class Crashed(uncaughtException: Throwable?): ContentState()
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a step in simplifying the complex interaction between these two classes. It also removes an unnecessary layer from the view tree.
We also had a potential bug on hot reloads, where the previous content was detached but not necessarily removed. With this change we clear the child views by default on a hot reload.
CHANGELOG.md
's "Unreleased" section has been updated, if applicable.