Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Wasm JS support #2207

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Remove Wasm JS support #2207

merged 1 commit into from
Jul 26, 2024

Conversation

JakeWharton
Copy link
Collaborator

It has weird testing flakes that should be impossible.

This reverts commit 7db3477


  • CHANGELOG.md's "Unreleased" section has been updated, if applicable.

It has weird testing flakes that should be impossible.

This reverts commit 7db3477
@JakeWharton
Copy link
Collaborator Author

Here's one:

app.cash.redwood.protocol.guest.GuestProtocolAdapterTest.modifierDefaultValueNotSerialized[wasmJs, node] FAILED
    AssertionFailedError: expected:<..."customType":"PT10S"[]})])]> but was:<..."customType":"PT10S"[,"string":"sup"]})])]>
        at kotlin.captureStackTrace(file:///Users/runner/work/redwood/redwood/build/js/packages/redwood-redwood-protocol-guest-wasm-js-test/kotlin/redwood-redwood-protocol-guest-wasm-js-test.uninstantiated.mjs:16)
        at <app.cash.redwood:redwood-protocol-guest_test>.kotlin.captureStackTrace__externalAdapter(wasm://wasm/<app.cash.redwood:redwood-protocol-guest_test>-0185a1c6)
        at <app.cash.redwood:redwood-protocol-guest_test>.kotlin.Throwable.<init>(wasm://wasm/<app.cash.redwood:redwood-protocol-guest_test>-0185a1c6)
        at <app.cash.redwood:redwood-protocol-guest_test>.kotlin.Throwable.<init>(wasm://wasm/<app.cash.redwood:redwood-protocol-guest_test>-0185a1c6)
        at <app.cash.redwood:redwood-protocol-guest_test>.kotlin.Error.<init>(wasm://wasm/<app.cash.redwood:redwood-protocol-guest_test>-0185a1c6)
        at <app.cash.redwood:redwood-protocol-guest_test>.kotlin.AssertionError.<init>(wasm://wasm/<app.cash.redwood:redwood-protocol-guest_test>-0185a1c6)
        at <app.cash.redwood:redwood-protocol-guest_test>.com.willowtreeapps.opentest4k.AssertionFailedError.<init>(wasm://wasm/<app.cash.redwood:redwood-protocol-guest_test>-0185a1c6)
        at <app.cash.redwood:redwood-protocol-guest_test>.com.willowtreeapps.opentest4k.AssertionFailedError.<init>(wasm://wasm/<app.cash.redwood:redwood-protocol-guest_test>-0185a1c6)
        at <app.cash.redwood:redwood-protocol-guest_test>.assertk.fail(wasm://wasm/<app.cash.redwood:redwood-protocol-guest_test>-0185a1c6)
        at <app.cash.redwood:redwood-protocol-guest_test>.assertk.assertions.support.expected(wasm://wasm/<app.cash.redwood:redwood-protocol-guest_test>-0185a1c6)

@JakeWharton JakeWharton merged commit 3bc9242 into trunk Jul 26, 2024
11 checks passed
@JakeWharton JakeWharton deleted the jw.wasm.2024-07-26 branch July 26, 2024 17:31
JakeWharton added a commit that referenced this pull request Jul 29, 2024
JakeWharton added a commit that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants