Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add leak detection API and module #2191

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Add leak detection API and module #2191

merged 1 commit into from
Jul 22, 2024

Conversation

JakeWharton
Copy link
Collaborator

This can be used to watch a reference when it is known to no longer be used, and to check whether or not it was collected by the Kotlin garbage collector or not.

Refs #2037


  • CHANGELOG.md's "Unreleased" section has been updated, if applicable.

This can be used to watch a reference when it is known to no longer be used, and to check whether or not it was collected by the Kotlin garbage collector or not.
Copy link
Member

@colinrtwhite colinrtwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this live in the Zipline repo instead of Redwood? Seems like it doesn't rely on any Redwood-specific classes.

@JakeWharton
Copy link
Collaborator Author

It doesn't rely on Zipline either. I'm only testing with Zipline to confirm its behavior inside QuickJS (which is that it both doesn't have a mechanism to trigger GC and that it doesn't support WeakRef).

It can live in its own repository someday if we want.

@JakeWharton JakeWharton merged commit d5defde into trunk Jul 22, 2024
11 checks passed
@JakeWharton JakeWharton deleted the jw.leaky.2024-07-03 branch July 22, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants