Fix a host crash in LazyListUpdateProcessor #2177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I introduced a bug in the mechanism that attempts to replace animated inserts and removes with update-in-place transitions. The crash occurs when the before window shrinks while the total number of elements is growing. The previous code naively assumed the before window shrinking would always be a scroll, but it can coincide with a content change. Closes: #2172
swankjesse
commented
Jul 10, 2024
| processor.items.insert(6, "I") | ||
| processor.onEndChanges() | ||
| processor.scrollTo(0, 12) | ||
| assertThat(processor.toString()).isEqualTo(". . C D E Fv2 G H I . . .") |
There was a problem hiding this comment.
The v2 after F here means there was an update-in-place, rather than a structural change. I’d like to do a follow-up to make these all say v2, which is how we reduce the glitchy animations in update processing.
swankjesse
commented
Jul 10, 2024
| processor.itemsAfter(2) | ||
| processor.onEndChanges() | ||
| processor.scrollTo(0, 12) | ||
| assertThat(processor.toString()).isEqualTo(". . . Cv2 D E F G H I . .") |
colinmarsch
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced a bug in the mechanism that attempts to replace animated inserts and removes with update-in-place transitions.
The crash occurs when the before window shrinks while the total number of elements is growing. The previous code naively assumed the before window shrinking would always be a scroll, but it can coincide with a content change.
Closes: #2172
CHANGELOG.md's "Unreleased" section has been updated, if applicable.