Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable the debug build type for libraries. #2032

Merged
merged 2 commits into from
May 16, 2024
Merged

Conversation

colinrtwhite
Copy link
Member

Looking for feedback on this. We need the debug build type for use with includeBuild.

I explored only enabling debug if redwood is used as part of includeBuild in another repo, but couldn't find an easy way (the projects maintain separate properties maps).

@colinrtwhite colinrtwhite requested a review from JakeWharton May 16, 2024 04:21
Copy link
Collaborator

@JakeWharton JakeWharton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh. Makes sense but I don't have to like it!

Lines 193-198 can also be deleted then.

@colinrtwhite colinrtwhite enabled auto-merge (squash) May 16, 2024 06:00
@colinrtwhite colinrtwhite merged commit de44f21 into trunk May 16, 2024
10 checks passed
@colinrtwhite colinrtwhite deleted the colin/debug branch May 16, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants