Reduce the number of retain cycles between host and guest #2029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
approved these changes
May 15, 2024
CHANGELOG.md
Outdated
| @@ -12,6 +12,7 @@ Changed: | |||
| - APIs accepting a `FileSystem` and `Path` now have the `FileSystem` coming before the `Path` in the parameter list. Compatibility functions are retained for this version, but will be removed in the next version. | |||
|
|
|||
| Fixed: | |||
| - Fix memory leaks caused by reference cycles on iOS. We got into trouble mixing garbage-collected Kotlin objects with reference-counted Swift objects. | |||
There was a problem hiding this comment.
Can you do a quick rebase? I released these notes a few hours ago and there's a new "Unreleased" section now.
There was a problem hiding this comment.
Oooh yep. Done.
swankjesse
force-pushed
the
jwilson.0515.break_the_cycle
branch
from
7ffef9b to
a6b742f
Compare
|
Ooooh darn. |
This isn't allowed in JavaScript.
JakeWharton
reviewed
May 15, 2024
| } | ||
| if (trait.parameterTypes.isEmpty()) { | ||
| beginControlFlow("{") | ||
| addStatement( | ||
| "%L(json, change.id, eventSink)::invoke", |
There was a problem hiding this comment.
Uuuuuggghhh I hate it. So wasteful. I wonder if ES6 or K2 or both will remove that implementation limitation for future optimization.
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.md's "Unreleased" section has been updated, if applicable.