Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename protocol modules #1975

Merged
merged 5 commits into from
Apr 17, 2024

Conversation

ahmed3elshaer
Copy link
Contributor

@ahmed3elshaer ahmed3elshaer commented Apr 17, 2024

This PR includes renaming operations to standardize the naming convention across the scheme protocols:

  • Renamed sample emoji scheme widget/protocol and compose/protocol to protocol-host and protocol-guest.
  • Updated the test app naming from widget-protocol to protocol-host.
  • Changed the test app compose-protocol to protocol-guest.

Fixes issue #1922


  • CHANGELOG.md's "Unreleased" section has been updated, if applicable.

@ahmed3elshaer
Copy link
Contributor Author

does this require updates in the changelog ?

@JakeWharton
Copy link
Collaborator

does this require updates in the changelog ?

No, since it doesn't effect end-users.

settings.gradle Outdated Show resolved Hide resolved
@JakeWharton
Copy link
Collaborator

Thanks for doing this!

@ahmed3elshaer
Copy link
Contributor Author

Thanks for doing this!

I'm glad that I can be of help!

@JakeWharton JakeWharton enabled auto-merge (squash) April 17, 2024 23:16
@JakeWharton JakeWharton merged commit 2341232 into cashapp:trunk Apr 17, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename protocol modules in emoji and test-app
2 participants