Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synthesize depth-first removes for old hosts #1936

Merged
merged 1 commit into from
Apr 5, 2024

Conversation

JakeWharton
Copy link
Collaborator

@JakeWharton JakeWharton commented Apr 4, 2024

This works around a since-fixed memory leak.

Fixing #1900 for old hosts via #1901.


  • CHANGELOG.md's "Unreleased" section has been updated, if applicable.

@JakeWharton JakeWharton force-pushed the jw.synthesize-removes.2024-04-03 branch from 82e54ff to d953e26 Compare April 4, 2024 13:26
Base automatically changed from jw.redwood-version.2024-04-02 to trunk April 4, 2024 13:54
@JakeWharton JakeWharton force-pushed the jw.synthesize-removes.2024-04-03 branch 2 times, most recently from 51950e3 to 4617f43 Compare April 4, 2024 13:58
This works around a since-fixed memory leak.
@JakeWharton JakeWharton force-pushed the jw.synthesize-removes.2024-04-03 branch from 4617f43 to 33362b0 Compare April 4, 2024 18:22
)
}

@Test fun entireSubtreeRemovedOldHostSynthesizesDepthFirstRemoval() = runTest {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SUPERCOOL

@JakeWharton JakeWharton merged commit 8dd7283 into trunk Apr 5, 2024
10 checks passed
@JakeWharton JakeWharton deleted the jw.synthesize-removes.2024-04-03 branch April 5, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants