Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update coil to v3.0.0-alpha03 #1779

Merged
merged 2 commits into from
Jan 21, 2024
Merged

Update coil to v3.0.0-alpha03 #1779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a90a67
Update coil to v3.0.0-alpha03
renovate[bot] Jan 21, 2024
fddc875
Update network dependency.
colinrtwhite Jan 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,8 @@ androidx-compose-ui = "1.5.4"
jbCompose = "1.5.11"
lint = "31.2.1"
zipline = "1.8.0"
coil = "3.0.0-alpha02"
coil = "3.0.0-alpha03"
okio = "3.7.0"
ktor = "2.3.7"

[libraries]
kotlin-compiler = { module = "org.jetbrains.kotlin:kotlin-compiler", version.ref = "kotlin" }
Expand Down Expand Up @@ -78,8 +77,7 @@ paparazzi-gradlePlugin = { module = "app.cash.paparazzi:paparazzi-gradle-plugin"
jimfs = "com.google.jimfs:jimfs:1.3.0"
coil-compose = { module = "io.coil-kt.coil3:coil-compose", version.ref = "coil" }
coil-core = { module = "io.coil-kt.coil3:coil", version.ref = "coil" }
coil-network = { module = "io.coil-kt.coil3:coil-network", version.ref = "coil" }
ktor-engine-okhttp = { module = "io.ktor:ktor-client-okhttp", version.ref = "ktor" }
Copy link
Member

@colinrtwhite colinrtwhite Jan 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Abstracted the network interface so we can remove the Ktor dependency on Android/JVM.

coil-network-okhttp = { module = "io.coil-kt.coil3:coil-network-okhttp", version.ref = "coil" }
turbine = "app.cash.turbine:turbine:1.0.0"
ktlint = "com.pinterest.ktlint:ktlint-cli:1.1.1"
googleJavaFormat = "com.google.googlejavaformat:google-java-format:1.19.2"
Expand Down
3 changes: 1 addition & 2 deletions samples/emoji-search/android-composeui/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,7 @@ android {

dependencies {
implementation libs.coil.compose
implementation libs.coil.network
implementation libs.ktor.engine.okhttp
implementation libs.coil.network.okhttp
implementation libs.google.material
implementation libs.kotlinx.coroutines.android
implementation projects.samples.emojiSearch.launcher
Expand Down
3 changes: 1 addition & 2 deletions samples/emoji-search/android-views/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,7 @@ android {

dependencies {
implementation libs.coil.core
implementation libs.coil.network
implementation libs.ktor.engine.okhttp
implementation libs.coil.network.okhttp
implementation libs.google.material
implementation libs.kotlinx.coroutines.android
implementation projects.samples.emojiSearch.launcher
Expand Down