Support the Emoji Search sample on desktop. #1755
Conversation
| override fun newImageLoader(context: Context): ImageLoader { | ||
| return ImageLoader.Builder(context) | ||
| .components { | ||
| add(NetworkFetcher.Factory()) |
There was a problem hiding this comment.
Network URL support currently has to be added manually as it was pulled out of coil-core. Ktor finds imported engines at runtime, which could also be done by Coil, but I'm not sure it's a good idea.
I'll look more into the PR later, but why was this done? The emoji sample is meant to be the Treehouse one. Is there something we can refactor towards to ensure it remains so that isn't available today? |
...h/composeui/src/commonMain/kotlin/com/example/redwood/emojisearch/composeui/ComposeUiText.kt
Outdated
Show resolved
Hide resolved
@JakeWharton I think we need a JVM instance of |
Almost certainly. It would go in a 'treehouse-host-composeui' module (if we don't already have one). It should really happen automatically as part of using If you refactor to keep the Android and JVM Desktop frontends in separate modules, I'd be okay with merging the direct usage and working towards getting it working on Treehouse over the coming weeks (or after I get back). |
colinrtwhite
force-pushed
the
colin/emojisearch_desktop
branch
from
f3556bb to
00bc31a
Compare
| val intent = Intent(Intent.ACTION_VIEW) | ||
| intent.setData(Uri.parse(url)) | ||
| startActivity(context, intent, null) | ||
| openUrl.invoke(url) |
|
|
It's hooked up directly the presenter on desktop similar to the counter sample.
Screen.Recording.2024-01-02.at.2.07.07.AM.mov