Return SizeOnlyPlaceholder when the placeholder queue is empty #1733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jesse Wilson <[email protected]>
jingwei99
commented
Dec 7, 2023
Comment on lines
-57
to
-63
|
|
||
| val visibleItemCount = localLastVisibleItemIndex - localFirstVisibleItemIndex | ||
| val proposedPlaceholderPoolSize = visibleItemCount + visibleItemCount / 2 | ||
| // We only ever want to increase the pool size. | ||
| if (placeholderPoolSize < proposedPlaceholderPoolSize) { | ||
| placeholderPoolSize = proposedPlaceholderPoolSize | ||
| } |
jingwei99
commented
Dec 7, 2023
Comment on lines
-108
to
-114
|
|
||
| val visibleItemCount = localLastVisibleItemIndex - localFirstVisibleItemIndex | ||
| val proposedPlaceholderPoolSize = visibleItemCount + visibleItemCount / 2 | ||
| // We only ever want to increase the pool size. | ||
| if (placeholderPoolSize < proposedPlaceholderPoolSize) { | ||
| placeholderPoolSize = proposedPlaceholderPoolSize | ||
| } |
jingwei99
commented
Dec 7, 2023
Comment on lines
+75
to
+81
| override fun createPlaceholder(original: View): View { | ||
| return object : View(value.context) { | ||
| override fun onMeasure(widthMeasureSpec: Int, heightMeasureSpec: Int) { | ||
| setMeasuredDimension(original.width, original.height) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
needs to be implemented on emoji search compose and iOS
jingwei99
commented
Dec 7, 2023
Comment on lines
+107
to
+109
| override fun uncaughtException(exception: Throwable) { | ||
| Log.e("Treehouse", "uncaughtException", exception) | ||
| } |
There was a problem hiding this comment.
not directly related, added it to make debugging easier
jingwei99
requested review from
swankjesse and
veyndan
and removed request for
swankjesse
This PR would return a |
swankjesse
approved these changes
Dec 8, 2023
jingwei99
deleted the
jingwei.return_SizeOnlyPlaceholder_for_empty_queue
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return a
SizeOnlyPlaceholderwhen the placeholder queue is empty, which could happen when:Follow up:
createPlaceholderfor iOS and Android compose emoji searchissues: