Upgrade to Zipline 1.7.0 #1718
Merged
Upgrade to Zipline 1.7.0 #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The '@contextual' is both unfortunate ane necessary. There's no automatic way for Zipline to customize encoding of built-in types, and the built-in encoding of longs loses precision. More details in this Zipline PR: cashapp/zipline#1171
veyndan
approved these changes
Dec 4, 2023
|
|
||
| @ObjCName("AppLifecycle", exact = true) | ||
| public interface AppLifecycle : ZiplineService { | ||
| public fun start(host: Host) | ||
|
|
||
| public fun sendFrame(timeNanos: Long) | ||
| public fun sendFrame(timeNanos: @Contextual Long) |
There was a problem hiding this comment.
This is a side point, but I feel like we've been overusing @Contextual. We very explicitly know what serializer we want to use here, and should probably opt for something as outlined at https://github.com/Kotlin/kotlinx.serialization/blob/master/docs/serializers.md#specifying-serializer-globally-using-typealias. Doing @Contextual just pushes all unregistered types to throw a runtime exception, which doesn't make sense if we know what serializer we always want for a specific case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The '@contextual' is both unfortunate ane necessary. There's no automatic way for Zipline to customize encoding of built-in types, and the built-in encoding of longs loses precision.
More details in this Zipline PR:
cashapp/zipline#1171