Fix bug replacing of root widget on UIKit #1706
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
We find bug on iOS with UIKit and redwood. Case:
create uikit with root
UIStackView
- just like in CounterApp sample:in delegate use
RedwoodUIView(root)
:but in Composable of our screen we should change root view by some condition (for example we change loading state to successful):
but istead of change root uiview we see that no changes.
reason - UIStackView add new child in arrangedSubviews (at 0 index) but remove child from subviews (that have different order). so when new UILabel added this label will be removed, instead of remove ColumnUIView