Add UI tests for Emoji Search Android frontends #1697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The view-based sample is currently crashing, which is why it's ignored.
JakeWharton
force-pushed
the
jw.emoji-tests.2023-11-22
branch
from
392ec01 to
7b5506f
Compare
JakeWharton
commented
Nov 23, 2023
...s/src/main/kotlin/com/example/redwood/emojisearch/android/tests/AbstractEmojiSearchUiTest.kt
Outdated
Show resolved
Hide resolved
dellisd
approved these changes
Nov 23, 2023
| - uses: reactivecircus/android-emulator-runner@v2 | ||
| with: | ||
| api-level: 29 | ||
| emulator-boot-timeout: 20000 |
There was a problem hiding this comment.
Have we ever really figured out why the emulator boot would timeout in SQLDelight PR checks?
Hopefully this doesn't introduce flakiness.
There was a problem hiding this comment.
We have two other jobs that already have emulators. They don't fail that often. Maybe one out of every 30 PRs. Not great, but not terrible either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The view-based sample is currently crashing, which is why it's ignored.
Refs #537. Refs #1696.