Fix column content changes #1688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swankjesse
force-pushed
the
jwilson.1117.resize_container
branch
from
91ec7ba to
2aa729d
Compare
swankjesse
changed the title
swankjesse
commented
Nov 19, 2023
There was a problem hiding this comment.
This one was broken before the code change. It showed the B at 50%, not at the bottom.
swankjesse
force-pushed
the
jwilson.1117.resize_container
branch
2 times, most recently
from
c532c61 to
54c9073
Compare
We had a bug where changes to a column's content wouldn't trigger all the necessary layout updates.
swankjesse
force-pushed
the
jwilson.1117.resize_container
branch
from
54c9073 to
7615b59
Compare
veyndan
approved these changes
Nov 20, 2023
Comment on lines
+70
to
+74
| rootNode.requestedWidth = Size.Undefined | ||
| rootNode.requestedMaxWidth = Size.Undefined | ||
| rootNode.requestedHeight = Size.Undefined | ||
| rootNode.requestedMaxHeight = Size.Undefined | ||
|
|
There was a problem hiding this comment.
Is there any downside to not specifying the requested sizes?
There was a problem hiding this comment.
This just clears them out so that we can set the ones we want below. Otherwise it ends up accumulating both exact and max values when it’s repeatedly measured.
There was a problem hiding this comment.
We should probably create an Issue to have these work with Compose UI so we don't forget about it
There was a problem hiding this comment.
I can do better than that. I can fix the problem!
#1691
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a bug where changes to a column's content wouldn't trigger all the necessary layout updates.