Propagate BackHandler#enabled changing in Redwood
#1673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veyndan
commented
Nov 8, 2023
Comment on lines
19
to
+25
| public var isEnabled: Boolean = enabled | ||
| set(value) { | ||
| field = value | ||
| enabledChangedCallback?.invoke() | ||
| } | ||
|
|
||
| public var enabledChangedCallback: (() -> Unit)? = null |
There was a problem hiding this comment.
This mechanism was inspired by Android's implementation:
veyndan
force-pushed
the
veyndan/2023-11-08/backhandler-propagate-enabled-android-views
branch
2 times, most recently
from
40a8850 to
6f77532
Compare
veyndan
changed the title
BackHandler#enabled changing in Redwood for Android ViewsBackHandler#enabled changing in Redwood
JakeWharton
approved these changes
Nov 9, 2023
veyndan
force-pushed
the
veyndan/2023-11-08/backhandler-propagate-enabled-android-views
branch
from
6f77532 to
7dc587f
Compare
veyndan
deleted the
veyndan/2023-11-08/backhandler-propagate-enabled-android-views
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only fixes the bug for Redwood. I'll make a follow up PR(s) to fix it for Treehouse.
Refs #1672