Add tests for BackHandler composable
#1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veyndan
force-pushed
the
veyndan/2023-11-07/BackHandler-tests
branch
from
06d09ba to
406eca9
Compare
veyndan
force-pushed
the
veyndan/2023-11-07/BackHandler-tests
branch
from
406eca9 to
1c71e36
Compare
colinrtwhite
approved these changes
Nov 7, 2023
JakeWharton
approved these changes
Nov 7, 2023
Comment on lines
+184
to
+186
| private suspend fun TestRedwoodComposition<List<WidgetValue>>.assertNoSnapshot() { | ||
| assertFailure { awaitSnapshot() }.isInstanceOf<TimeoutCancellationException>() | ||
| } |
There was a problem hiding this comment.
I wonder if we can provide a proper API for this rather than relying on the timeout.
| } | ||
|
|
||
| fun onBackPressed() { | ||
| val callbackToNotify = onBackPressedCallbacks.lastOrNull { it.isEnabled } |
There was a problem hiding this comment.
Because this fake implements the behavior that chooses the last callback to invoke, the tests which put multiple back handlers into the composition (at least when both are enabled) are exercising this behavior and not any actual library behavior.
There was a problem hiding this comment.
Good point. Just updated the PR to inline this function and add the desired assertions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.