Scope all events to a code session #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swankjesse
commented
Nov 1, 2023
| @@ -46,9 +47,10 @@ public class TreehouseApp<A : AppService> private constructor( | |||
| ) { | |||
| private val codeHost = ZiplineCodeHost<A>() | |||
|
|
|||
| public val dispatchers: TreehouseDispatchers = factory.dispatchers | |||
| // TODO: remove after https://github.com/cashapp/zipline/pull/1159 | |||
| private val ziplineToPublisherHack = mutableMapOf<Zipline, RealEventPublisher>() | |||
There was a problem hiding this comment.
I’m massively cheating here 'cause I want to correlate the Zipline-layer EventListener with the Treehouse-layer EventListener, but I don’t control the creation of the Zipline-layer one.
That PR has the fix!
There was a problem hiding this comment.
I’d like to hold this until I can rebase on that upgrade.
This gives us a code version to attribute failures to. This is a backwards-incompatible change; we need to pass an EventListener.Factory instead of an EventListener when creating a TreehouseApp. This drops the appStart() and appCanceled() events. These are roughly approximated by the scoped codeLoadStart() and codeUnloaded() functions.
swankjesse
force-pushed
the
jwilson.1101.scope_to_code_session
branch
from
452ef54 to
87b9818
Compare
JakeWharton
approved these changes
Nov 3, 2023
|
Part of #1458 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives us a code version to attribute failures to.
This is a backwards-incompatible change; we need to pass an EventListener.Factory instead of an EventListener when creating a TreehouseApp.
This drops the appStart() and appCanceled() events. These are roughly approximated by the scoped codeLoadStart() and codeUnloaded() functions.