Handle uncaught exceptions from async calls #1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
async_crash.mp4 |
swankjesse
commented
Oct 30, 2023
| * When a Treehouse app fails its current [Zipline] instance is canceled so no further code will | ||
| * execute. A new [Zipline] will start when new code available, or when the app is restarted. | ||
| */ | ||
| public open fun uncaughtException( |
There was a problem hiding this comment.
For follow-up, I’d like more Zipline-specific context here. The ZiplineManifest has the release version, and that’ll be super valuable for reporting upstream.
|
Part of #1458 |
|
JakeWharton
approved these changes
Oct 31, 2023
redwood-treehouse/src/commonMain/kotlin/app/cash/redwood/treehouse/AppLifecycle.kt
Outdated
Show resolved
Hide resolved
swankjesse
force-pushed
the
jwilson.1028.uncaught_exceptions
branch
from
54e0a63 to
3c6ff73
Compare
When the guest throws an uncaught exception, a guest-side CoroutineExceptionHandler now forwards it to the host via AppLifecycle.handleUncaughtException(). That now triggers a graceful break of all UIs.
…ouse/AppLifecycle.kt Co-authored-by: Jake Wharton <[email protected]>
swankjesse
force-pushed
the
jwilson.1030.uncaught_exceptions_async
branch
from
eb89498 to
603b8ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the guest throws an uncaught exception, a guest-side CoroutineExceptionHandler now forwards it to the host via AppLifecycle.handleUncaughtException(). That now triggers a graceful break of all UIs.