Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate enum indirection to values #1608

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Eliminate enum indirection to values #1608

merged 1 commit into from
Oct 18, 2023

Conversation

JakeWharton
Copy link
Collaborator

No description provided.

veyndan
veyndan approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@veyndan veyndan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was necessary when we were using @TestParameterInjector. Makes sense to remove it now that we're no longer depending on it.

@JakeWharton JakeWharton merged commit 8fa72b2 into trunk Oct 18, 2023
8 checks passed
@JakeWharton JakeWharton deleted the jw.enum-enomore.2023-10-17 branch October 18, 2023 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veyndan veyndan veyndan approved these changes

@swankjesse swankjesse Awaiting requested review from swankjesse

@colinrtwhite colinrtwhite Awaiting requested review from colinrtwhite

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JakeWharton @veyndan