Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using FileStateStore instead of MemoryStore in TestApp #1595

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Using FileStateStore instead of MemoryStore in TestApp #1595

merged 1 commit into from
Oct 16, 2023

Conversation

ahmed3elshaer
Copy link
Contributor

As discussed in #1518 FileStateStore is required to survive configuration changes in Android.

After testing every screen state is saved as expected 🚀 , thanks to @veyndan 🙏🏼

Side notes : Sometimes the back button functionality doesn't work in Repo Search screen

@ahmed3elshaer ahmed3elshaer mentioned this pull request Oct 15, 2023
Closed
veyndan
veyndan approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@veyndan veyndan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think copy-pasting FileStateStore from Emoji Search is a good trade-off until we have a better default StateStore implementation. Thanks for the PR!

@veyndan veyndan merged commit 4da6257 into cashapp:trunk Oct 16, 2023
8 checks passed
@ahmed3elshaer
Copy link
Contributor Author

@veyndan glad that i can help 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veyndan veyndan veyndan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahmed3elshaer @veyndan