Share snapshot callback and improve its output #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
commented
Oct 12, 2023
There was a problem hiding this comment.
If no name is provided a counter is implicitly used.
JakeWharton
commented
Oct 12, 2023
| private let testName: String | ||
| private let fileName: StaticString | ||
|
|
||
| init(named testName: String, _ fileName: StaticString = #file) { |
There was a problem hiding this comment.
I don't quite understand how it works, but this default is evaluated in the context of the caller which is very different from how Kotlin does it. As a result, we get to capture the name of the calling file automatically.
There was a problem hiding this comment.
colinrtwhite
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.