Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update UIView Box Implementation #1577

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Update UIView Box Implementation #1577

merged 1 commit into from
Oct 12, 2023

Conversation

underscoretang
Copy link
Collaborator

@underscoretang underscoretang commented Oct 10, 2023 •
edited
Loading

  • Replacing Button with Rectangle here to make it debuggable visually.
  • Updates were needed to handle width and height dp modifiers.

Simulator Screen Shot - iPhone 14 Pro - 2023-10-10 at 16 13 28

@underscoretang
Copy link
Collaborator Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@underscoretang underscoretang enabled auto-merge (squash) October 12, 2023 16:01
@underscoretang
Update UIView Box Implementation
bd83ca7 
- Replaces Button with Rectangle in the Sandbox screen
- Fix for certain combinations of Wrap + Stretch not rendering correctly
- Introduce handling for explicit width and height modifiers
@underscoretang underscoretang merged commit 9cf3c0c into trunk Oct 12, 2023
8 checks passed
@underscoretang underscoretang deleted the box/ui-view-updates branch October 12, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jingwei99 jingwei99 jingwei99 approved these changes

@JakeWharton JakeWharton JakeWharton approved these changes

@swankjesse swankjesse Awaiting requested review from swankjesse

@colinrtwhite colinrtwhite Awaiting requested review from colinrtwhite

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@underscoretang @JakeWharton @jingwei99