Promote AbstractFlexContainerTest to commonMain #1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swankjesse
commented
Oct 10, 2023
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright (C) 2022 Square, Inc. | |||
| * Copyright (C) 2023 Square, Inc. | |||
There was a problem hiding this comment.
I assume a robot did this? I have no recollection.
There was a problem hiding this comment.
If you F6 a file it will update the copyright for some reason.
This requires parameterized tests to be manually exploded into their cartesian product.
swankjesse
force-pushed
the
jwilson.1010.burst
branch
from
2994e16 to
0461c91
Compare
JakeWharton
approved these changes
Oct 10, 2023
Comment on lines
+334
to
+337
| /** We don't have assume() on kotlin.test. Tests that fail here should be skipped instead. */ | ||
| private fun assumeTrue(b: Boolean) { | ||
| assertTrue(b) | ||
| } |
There was a problem hiding this comment.
Delete? And delete call-sites? Presumably you did not create invalid variants when exploding them.
There was a problem hiding this comment.
I didn’t, but I want to keep the assume calls around for when we later do burst.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires parameterized tests to be manually exploded into their cartesian product.