Use LazyListUpdateProcessor for Android views #1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swankjesse
commented
Oct 6, 2023
| @@ -250,15 +250,13 @@ internal class LazyListContainerCell( | |||
|
|
|||
| // Unbind the cell when its view is detached from the table. | |||
| if (superview != null && newSuperview == null) { | |||
| removeAllSubviews() | |||
There was a problem hiding this comment.
This is now performed by unbind() below.
swankjesse
commented
Oct 6, 2023
| } else if (holder.container.height == 0) { | ||
| // This occurs when the ViewHolder has been freshly created, so we set the container | ||
| // to a non-zero height so that it's visible. | ||
| holder.itemView.updateLayoutParams { height = lastItemHeight } |
There was a problem hiding this comment.
Big regression here . . . I need to add a hook to create placeholders on-demand.
There was a problem hiding this comment.
Tracking here: #1571
swankjesse
commented
Oct 6, 2023
| } | ||
|
|
||
| private class FakeWindowedLazyList : WindowedLazyList<WidgetValue>(NoOpListUpdateCallback) { |
There was a problem hiding this comment.
Previously we used the compose-side LazyList to drive this on the widget-side.
With FakeProcessor we’ve got a test facet for the widget side and I don’t think this integration test is necessary.
swankjesse
commented
Oct 6, 2023
| // This incorrectly updates the viewport, which then shifts the loaded items window. | ||
| // This then increases the value of itemsBefore, | ||
| // and the cycle continues until the backing dataset is exhausted. | ||
| adapter.notifyDataSetChanged() |
swankjesse
force-pushed
the
jwilson.1006.actually_recycler_view
branch
from
75d3d4f to
f08c6e0
Compare
lazylist.mp4 |
JakeWharton
approved these changes
Oct 10, 2023
swankjesse
force-pushed
the
jwilson.1006.actually_recycler_view
branch
from
f08c6e0 to
1cbcff1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1552