Embed the Zipline app in Android app assets #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the app to function without the server running, or without ever having to had connect to the server in the past. It will also allow automated testing of these applications in the future.
JakeWharton
force-pushed
the
jw.embed-zipline-application.2023-10-05
branch
from
cb055d8 to
56c31da
Compare
JakeWharton
commented
Oct 5, 2023
Comment on lines
+63
to
+79
| // Add a timestamp to the manifest which is required for Zipline to load as an embedded app. | ||
| val outputManifest = inputManifest.copy( | ||
| unsigned = inputManifest.unsigned.copy( | ||
| freshAtEpochMs = System.currentTimeMillis(), | ||
| ), | ||
| ) | ||
| val outputManifestFile = outputDirectory.file("${appName.get()}.$ZIPLINE_MANIFEST_JSON").asFile | ||
| outputManifestFile.writeText(outputManifest.encodeJson()) | ||
|
|
||
| // Rewrite all .zipline files to their SHA-256 hashes which is how Zipline loads when embedded. | ||
| for (module in outputManifest.modules.values) { | ||
| val inputFile = checkNotNull(fileMap.remove(module.url)) { | ||
| "No ${module.url} file found in input files as specified by the manifest" | ||
| } | ||
| val outputFile = outputDirectory.file(module.sha256.hex()).asFile | ||
| inputFile.copyTo(outputFile) | ||
| } |
There was a problem hiding this comment.
Future change: going to move all this to happen on the production-side rather than the consumer-side so as to support iOS more easily.
There was a problem hiding this comment.
And move this to the Zipline Gradle plugin!
swankjesse
reviewed
Oct 6, 2023
| /** Bundle a zip with dependencies and startup scripts. */ | ||
| fun application(name: String, mainClass: String) | ||
| /** Bundle a zip with dependencies and startup scripts for a CLI. */ | ||
| fun cliApplication(name: String, mainClass: String) |
There was a problem hiding this comment.
I really like how this plugin is structured
swankjesse
reviewed
Oct 6, 2023
| @@ -374,4 +376,74 @@ private class RedwoodBuildExtensionImpl(private val project: Project) : RedwoodB | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| override fun ziplineApplication() { | |||
There was a problem hiding this comment.
I aught to move this behavior to Zipline itself!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the app to function without the server running, or without ever having to had connect to the server in the past. It will also allow automated testing of these applications in the future.
Refs #537
Views:
Compose UI:
