Add UIKit screenshot tests for layout's Spacer
#1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
force-pushed
the
jw.layout-uiview-screenshot-testing.2023-09-29
branch
from
534935c to
320d8d7
Compare
JakeWharton
commented
Sep 29, 2023
Comment on lines
+4
to
+9
| /** | ||
| * An abstract base class for hosting Kotlin test classes in Swift projects. | ||
| * | ||
| * Subclasses must override `initTest(name:)` to create instances of `KotlinType`. | ||
| */ | ||
| open class KotlinHostingXCTestCase<KotlinTest>: KotlinHostingXCTestCaseHelper where KotlinTest: NSObject { |
There was a problem hiding this comment.
Here be crimes
JakeWharton
commented
Sep 29, 2023
Comment on lines
+5
to
+9
| final class UIViewSpacerTestHost: KotlinHostingXCTestCase<UIViewSpacerTest> { | ||
| override class func initTest(name: String) -> UIViewSpacerTest { | ||
| return UIViewSpacerTest(callback: Callback(named: name)) | ||
| } | ||
| } |
There was a problem hiding this comment.
But this is 👨🍳💋
This adds the start of a new setup for hosting Kotlin tests within an iOS project so that we can use a Swift screenshot testing library. For now you have to prefix your test functions with "test" and any before/after-annotated functions need to be named "setUp" and "tearDown" (very JUnit 3). We also do not support anything JVM-specific like rules or parameterization for now.
JakeWharton
force-pushed
the
jw.layout-uiview-screenshot-testing.2023-09-29
branch
from
320d8d7 to
3d4411e
Compare
efirestone
approved these changes
Oct 3, 2023
swankjesse
approved these changes
Oct 4, 2023
Comment on lines
+4
to
+9
| /** | ||
| * An abstract base class for hosting Kotlin test classes in Swift projects. | ||
| * | ||
| * Subclasses must override `initTest(name:)` to create instances of `KotlinType`. | ||
| */ | ||
| open class KotlinHostingXCTestCase<KotlinTest>: KotlinHostingXCTestCaseHelper where KotlinTest: NSObject { |
|
|
||
| private static func createTestMethod(target: KotlinTest, selector: Selector) { | ||
| let block: @convention(block) () -> Void = { | ||
| if target.responds(to: #selector(setUp)) { |
| if target.responds(to: #selector(setUp)) { | ||
| target.perform(#selector(setUp)) | ||
| } | ||
| defer { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the start of a new setup for hosting Kotlin tests within an iOS project so that we can use a Swift screenshot testing library. For now you have to prefix your test functions with "test" and any before/after-annotated functions need to be named "setUp" and "tearDown" (very JUnit 3). We also do not support anything JVM-specific like rules or parameterization for now.
Refs #1343