-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify creation of new screens #1525
Conversation
This also changes from an enum key to a string key so that we can switch to rememberSaveable soon.
if (content == null) { | ||
Text("No screen found with key '$screenKey'!") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about automatically falling back to home, but if we get rememberSaveable
, you rename a key, and the app reloads, I want what happened to be slightly more clear.
class TestContext( | ||
val httpClient: HttpClient, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will become a context receiver eliminating the need to explicitly pass any values in the lambdas above.
@JakeWharton I appreciate your effort in doing this task. I tried to implement #1518 yesterday, but it did not work as expected. I realized that the reason was the enum screen now. |
Yeah a string should work much better with |
This also changes from an enum key to a string key so that we can switch to rememberSaveable soon (#1518).