Stick to the safe area when rendering test app #1512
Conversation
| tv.translatesAutoresizingMaskIntoConstraints = false | ||
|
|
||
| self.view.addSubview(tv) | ||
| let safeGuide = self.view.safeAreaLayoutGuide |
There was a problem hiding this comment.
I think instead of all of this, you could maybe just do
tv.bounds = view.safeAreaLayoutGuide.layoutFrame
There was a problem hiding this comment.
Oh sweet. Will try.
There was a problem hiding this comment.
If this works, it's worth pointing out that it's a bit backwards/unconventional--a UIView's bounds rect is expressed relative to the view's own coordinate system, whereas its frame rect is expressed relative to its superview's coordinate system. It's more typical to declare mySubview.frame = mySuperview.bounds, to get mySubview to fill mySuperview's rect.
In this case, view.safeAreaLayoutGuide.layoutFrame is expressed view's coordinate system, not tv's.
There was a problem hiding this comment.
Looks like they're not exactly in the same coordinate system and the bound origin or something gets skewed by half the height/width. Even when I fix it (or try to) it occupies the whole screen still rather than only the safe area.
There was a problem hiding this comment.
Going to merge as-is. Hopefully soon we'll have a scaffolding-like composable in this app which gets us a traditional top/nav bar on Android and iOS (and will allow drawing edge-to-edge again).
There was a problem hiding this comment.
Good to know--it was worth a shot. Definitely safe to merge as is!
Did I do any of this right? It looks right...