Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support RTL layout direction in redwood-layout-dom #1509

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Support RTL layout direction in redwood-layout-dom #1509

merged 1 commit into from
Sep 26, 2023

Conversation

ahmed3elshaer
Copy link
Contributor

@ahmed3elshaer ahmed3elshaer commented Sep 24, 2023 •
edited
Loading

Changes

  • marginInlineStart and marginInlineEnd as extension properties for CSSStyleDeclaration that represents ""margin-inline-start" and ""margin-inline-end"
  • Replaced marginLeft and marginRight with marginInlineStart and marginInlineEnd respectively

Fixes #1244

JakeWharton
JakeWharton approved these changes Sep 25, 2023
View reviewed changes
Copy link
Collaborator

@JakeWharton JakeWharton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I don't quite understand how to choose between margin-inline-start and margin-block-start though. Since we don't have any DOM customers I'm inclined to just merge and figure out later. What do you think?

veyndan
veyndan approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@veyndan veyndan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This works well if the direction is set to RTL. It'll change the positioning vertically when changing to certain writing modes, but I'm not sure whether that's desired or not. Agreed that we should just merge it and see later!

@JakeWharton JakeWharton merged commit 052acf1 into cashapp:trunk Sep 26, 2023
@ahmed3elshaer ahmed3elshaer deleted the dom-rtl-layout-direction-support branch September 28, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veyndan veyndan veyndan approved these changes

@JakeWharton JakeWharton JakeWharton approved these changes

@colinrtwhite colinrtwhite Awaiting requested review from colinrtwhite

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support RTL layout direction in redwood-layout-dom
3 participants
@ahmed3elshaer @JakeWharton @veyndan