Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ButtonBinding.swift click action error! #1507

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

hxxyyangyong
Copy link
Contributor

@hxxyyangyong hxxyyangyong commented Sep 22, 2023

The interface method of Button is implemented in ButtonBinding, but the root button executes the interface method again, resulting in the inability to call back the Unit in Kotlin. Here, the assigned attribute OnClick should be called.

Closes #1506

@hxxyyangyong
Copy link
Contributor Author

@JakeWharton

@JakeWharton JakeWharton enabled auto-merge (squash) September 25, 2023 20:35
@JakeWharton JakeWharton merged commit c138de2 into cashapp:trunk Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test-app ios project ButtonBinding logic error
3 participants